Address redundant errors for missing crate for nested imports and later uses of crate by yuk1ty · Pull Request #153956 · rust-lang/rust

yuk1ty · 2026-03-16T13:55:13Z

Basically I merged redundant E0433 errors into E0432. The change seems to affect other related tests.

The first commit handles the nested import case. The second commit handles to suppress foo::qux() pattern.

rustbot · 2026-03-16T13:55:19Z

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 15 candidates

…t path

rustbot · 2026-03-25T13:37:01Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Track first segments of failed imports and skip late resolution errors for paths sharing the same prefix. This avoids redundant E0433 after an E0432 has already been reported for the same missing module, without suppressing unrelated diagnostics.

rust-bors · 2026-04-28T01:25:44Z

☔ The latest upstream changes (presumably #155890) made this pull request unmergeable. Please resolve the merge conflicts.

Enselic · 2026-07-03T18:44:38Z


 mod B {
-    use A::{::Fish}; //~ ERROR the crate root in paths can only be used in start position
+    use A::{::Fish}; //~ ERROR unresolved import `A::Fish`


Hello. This is an unwanted regression in diagnostics, isn't it? In case you haven't looked through all diagnostic output changes and made sure they are all sensible, please do that. Thanks!

View changes since the review

rustbot · 2026-07-03T18:44:48Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

cjgillot · 2026-06-03T08:38:41Z

 #![allow(unused_imports)]

-mod foo {}
-


This is changing the purpose of the test. Please prefer creating another one.

View changes since the review

cjgillot · 2026-06-03T08:41:42Z

+    /// First segments of import paths that failed to resolve.
+    /// Used to suppress redundant resolution errors in late resolver
+    /// for paths sharing the same unresolved prefix.
+    failed_import_prefixes: FxHashSet<Symbol>,


This may be sufficient for a single-file test case. What if the prefix exists in one file and not another one?

View changes since the review

rustbot assigned dingxiangfei2009 Mar 16, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2026